Differential D26072

Remove old PHP5 code from HTTPSFuture
ClosedPublic
Actions

Authored by aklapper on Mon, Jun 9, 12:37.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARCe8f8feb6fdeb: Remove old PHP5 code from HTTPSFuture

Summary

See https://www.php.net/manual/en/class.curlfile.php.
Phorge requires PHP 7.2 since rP7d8c84a7bdc8fb43674341b97c36c9d8ae1d894a so also remove these pre-PHP 7.2 checks in Arcanist.
This change soft-depends on D26071.

Test Plan

Read the code.

Diff Detail

Repository

rARC Arcanist

Branch

php530curlcheck (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2078
Build 2078: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Jun 9, 12:37

Owners added a reviewer: O1: Blessed Committers.Mon, Jun 9, 12:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Jun 9, 12:37

aklapper requested review of this revision.Mon, Jun 9, 12:37

Harbormaster completed remote builds in B2078: Diff 3191.Mon, Jun 9, 12:37

valerio.bozzolan accepted this revision.Thu, Jun 12, 06:57

This revision is now accepted and ready to land.Thu, Jun 12, 06:57

Closed by commit rARCe8f8feb6fdeb: Remove old PHP5 code from HTTPSFuture. · Explain WhyThu, Jun 12, 08:39

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARCe8f8feb6fdeb: Remove old PHP5 code from HTTPSFuture.

aklapper mentioned this in Next Up.Thu, Jun 12, 08:39

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

future/

http/

HTTPSFuture.php

21 lines

O1: Blessed Committers

Diff 3191

View Options

src/future/http/HTTPSFuture.php

Remove old PHP5 code from HTTPSFutureClosedPublicActions