Page MenuHomePhorge

Allow using PCRE's just-in-time compilation
Needs ReviewPublic

Authored by aklapper on Sat, May 24, 12:49.

Details

Summary

Do not disable the PCRE JIT compiler by default but instead allow a potential performance boost for folks who have PCRE2 installed.

The current code was introduced in rPHU1422024de70d / https://web.archive.org/web/20240805021512/http://secure.phabricator.com/T13296 to work around an issue appearing in 2019 on Mac OS with early PHP 7.3 versions.

Online comments like https://github.com/bobthecow/psysh/issues/540#issuecomment-547847844 or https://github.com/squizlabs/PHP_CodeSniffer/issues/2475#issuecomment-862579574 imply that later PHP 7.3 versions work as expected.
Thus do not take all and any installations of Phorge into performance custody for some scope limited problem which existed six years ago.

See also https://www.php.net/manual/en/pcre.configuration.php#ini.pcre.jit

Closes T16084

Test Plan

Unclear but I don't care much anyway. Probably requires people with Mac OS machines and ancient PHP versions installed, maybe the test case in https://web.archive.org/web/20240805021512/http://secure.phabricator.com/T13296 could be used. Shrug.

Diff Detail

Repository
rARC Arcanist
Branch
T16084pcreJit (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2013
Build 2013: arc lint + arc unit