AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72
ClosedPublic
Actions

Authored by valerio.bozzolan on Tue, May 20, 13:39.

Details

Reviewers

mainframe98
aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time)

Commits

rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from…

Summary

Closes T16082

Test Plan

Visit this page:

http://phorge.localhost/calendar/event/edit/form/default/?start=1747749600&end=1747753200

No warning anymore from your Dark Console.

The Start and End fields are still prefixed with '2025-05-20', so, no regressions.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2005
Build 2005: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Tue, May 20, 13:39

Owners added a reviewer: O1: Blessed Committers.Tue, May 20, 13:39

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptTue, May 20, 13:39

valerio.bozzolan requested review of this revision.Tue, May 20, 13:39

Harbormaster completed remote builds in B2005: Diff 3084.Tue, May 20, 13:39

mainframe98 accepted this revision.Tue, May 20, 15:50

Thanks! Confirming; tested, also works as expected with other epoch values.

This revision is now accepted and ready to land.Tue, May 20, 16:21

Closed by commit rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from…. · Explain WhyWed, May 21, 09:59

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….

Revision Contents
Changeset List

Path

Size

Packages

src/

view/

form/

control/

AphrontFormDateControlValue.php

4 lines

O1: Blessed Committers

Diff 3084

View Options

src/view/form/control/AphrontFormDateControlValue.php

AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72ClosedPublicActions