Paths

Table of Contentst

Differential D26023

Ignore bogus cards parameter string values in Hovercards calls
AcceptedPublic
Actions

Authored by aklapper on Sun, May 18, 20:35.

Tags

None

Referenced Files

	F4317855: D26023.1748112489.diff
	Fri, May 23, 18:48

	F4317806: D26023.1748112049.diff
	Fri, May 23, 18:40

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php

Summary

Do not throw an exception when passing bogus parameter string values to hovercards. Instead, just convert to an empty array.
In consequence, see a proper hovercard correctly displaying Unknown Object (????) instead of an exception:

EXCEPTION: (TypeError) idx(): Argument #1 ($array) must be of type array, string given, called in /var/www/html/phorge/phorge/src/applications/search/controller/PhabricatorSearchHovercardController.php on line 37 at [<arcanist>/src/utils/utils.php:37]

See also similar rPa5384ca60470e56a5312d5a7147ddd3ffa2e75d8.

Closes T16075

Test Plan

Go to http://phorge.localhost/search/hovercard/?__path__=%2fsearch%2fhovercard%2f&cards={"layout":"foo"}
Get an error message before applying the patch. Get an empty hovercard after applying the patch.

Diff Detail

Repository

Branch

hovercardsIdxArray (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1987
Build 1987: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, May 18, 20:35

Owners added a reviewer: O1: Blessed Committers.Sun, May 18, 20:35

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, May 18, 20:35

aklapper requested review of this revision.Sun, May 18, 20:35

Harbormaster completed remote builds in B1986: Diff 3060.Sun, May 18, 20:35

valerio.bozzolan added inline comments.Sun, May 18, 20:44

src/applications/search/controller/PhabricatorSearchHovercardController.php
104	is_array() 👍 (alsorecommended by the manual of gettype) also above

aklapper marked an inline comment as done.Sun, May 18, 21:04

Sigh, I swear I grep'ed for isArray before but I was in a parallel CamelCase world in that moment

Harbormaster completed remote builds in B1987: Diff 3061.Sun, May 18, 21:05

sgtm

src/applications/search/controller/PhabricatorSearchHovercardController.php
13	Wow. We have our own JSON parser. Related task: T16076: Understand if we still need our own JSON parser

This revision is now accepted and ready to land.Mon, May 19, 07:00

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

6 lines

2%

Loading...

O1: Blessed Committers

Diff 3061

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...