Paths

Table of Contentst

Differential D26010

Remove orphan CSS selectors in core/z-index.css
ClosedPublic
Actions

Authored by aklapper on Sat, May 10, 11:25.

Tags

None

Referenced Files

	F4285775: D26010.1747463172.diff
	Fri, May 16, 06:26

	F4281847: D26010.1747413761.diff
	Thu, May 15, 16:42

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css

Summary

project-board-header
- Added in 183dd2a62764f0c2b5fd5f234cc4356d657a1069, usage removed in https://we.phorge.it/rP6349741760a84de46f6a53d57fadef3b044b15ee also from webroot/rsrc/css/phui/phui-workboard-view.css but not from core/z-index.css
pholio-new-inline-comment
- Added in https://we.phorge.it/rPe5af167ec99cdb29fcb3bb44e44c5afd3d0c6d7e, .pholio-new-inline-comment was removed from webroot/rsrc/css/application/pholio/pholio-inline-comments.css in https://we.phorge.it/rP85870e79aaf2f5dd0065f7b84d2e491062929027 but not from core/z-index.css; usage was removed in https://we.phorge.it/rP942f504893578c361c02727a4b615c70dc761af9 by deleting src/applications/pholio/view/PholioInlineCommentSaveView.php

For further cleanups in core/z-index.css, see D25997.

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.

Diff Detail

Repository

Branch

cssDead17 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1977
Build 1977: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, May 10, 11:25

Owners added a reviewer: O1: Blessed Committers.Sat, May 10, 11:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, May 10, 11:25

aklapper requested review of this revision.Sat, May 10, 11:25

Harbormaster completed remote builds in B1966: Diff 3028.Sat, May 10, 11:25

Wow. This specific CSS stylesheet z-index.css is totally mind-blowing. Whatever cursed code pattern we invented here, we are alone in the universe in doing this lol. God forgive our souls pls.

This revision is now accepted and ready to land.Wed, May 14, 12:04

git rebase master

Harbormaster completed remote builds in B1977: Diff 3045.Wed, May 14, 22:33

Closed by commit rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css. · Explain WhyWed, May 14, 22:34

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

core/

8 lines

O1: Blessed Committers

Diff 3045

resources/celerity/map.php

Loading...

webroot/rsrc/css/core/z-index.css

Loading...