Differential D25977

PHPDoc: Correct some param types
AcceptedPublic
Actions

Authored by aklapper on Sun, Apr 27, 11:24.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

Type in PHPDoc @param versus type in method signature mismatch. Thus correct PHPDoc.

Test Plan

Read the PHPDoc and the signature and compare types.

Diff Detail

Repository

rP Phorge

Branch

phpdocParamTypes (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1896
Build 1896: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Apr 27, 11:24

Owners added a reviewer: O1: Blessed Committers.Sun, Apr 27, 11:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Apr 27, 11:24

aklapper requested review of this revision.Sun, Apr 27, 11:24

Harbormaster completed remote builds in B1896: Diff 2927.Sun, Apr 27, 11:24

yesyes

This revision is now accepted and ready to land.Mon, Apr 28, 06:57

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

4 lines

O1: Blessed Committers

base/

PhabricatorApplication.php

4 lines

29%

O1: Blessed Committers

people/

storage/

PhabricatorUser.php

2 lines

27%

O1: Blessed Committers

Diff 2927

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/people/storage/PhabricatorUser.php

PHPDoc: Correct some param typesAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2927

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

src/applications/base/PhabricatorApplication.php

src/applications/people/storage/PhabricatorUser.php

PHPDoc: Correct some param types
AcceptedPublic
Actions

Revision Contents
Changeset List