Page MenuHomePhorge

Avoid "No such token" exception going to /token/give/ directly
Needs ReviewPublic

Authored by aklapper on Tue, Mar 4, 17:31.
Tags
None
Referenced Files
F3223357: D25903.1741939828.diff
Thu, Mar 13, 08:10
F3216208: D25903.1741685597.diff
Mon, Mar 10, 09:33
F3216106: D25903.1741679229.diff
Mon, Mar 10, 07:47
F3215540: D25903.1741649514.diff
Sun, Mar 9, 23:31
F3214487: D25903.1741555528.diff
Sat, Mar 8, 21:25
F3212968: D25903.1741538020.diff
Sat, Mar 8, 16:33
F3212930: D25903.1741524652.diff
Sat, Mar 8, 12:50
F3168003: D25903.1741266914.diff
Wed, Mar 5, 13:15

Details

Summary

Handle bots doing strange things more gracefully by not throwing a noisy uninteresting exception in my error log.

EXCEPTION: (Exception) No such token ""! at [<phorge>/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php:153]

Closes T16006

Test Plan
  • Go to /token/give/PHID-TASK-someValidId/ and click one of the tokens, compare Phorge behavior before and after patch
  • Go to a task, in the sidebar, click "Award a Token" and "Rescind a Token": Still works as before

Diff Detail

Repository
rP Phorge
Branch
T16006TokenExcpt (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1764
Build 1764: arc lint + arc unit