Page MenuHomePhorge

Avoid "No such token" exception going to /token/give/ directly
Needs ReviewPublic

Authored by aklapper on Tue, Mar 4, 17:31.
Tags
None
Referenced Files
F3248263: D25903.1742247089.diff
Sun, Mar 16, 21:31
F3245737: D25903.1742191799.diff
Sun, Mar 16, 06:09
F3245681: D25903.1742188617.diff
Sun, Mar 16, 05:16
F3224443: D25903.1742030035.diff
Fri, Mar 14, 09:13
F3223641: D25903.1741994641.diff
Thu, Mar 13, 23:24
F3223357: D25903.1741939828.diff
Thu, Mar 13, 08:10
F3216208: D25903.1741685597.diff
Mon, Mar 10, 09:33
F3216106: D25903.1741679229.diff
Mon, Mar 10, 07:47

Details

Summary

Handle bots doing strange things more gracefully by not throwing a noisy uninteresting exception in my error log.

EXCEPTION: (Exception) No such token ""! at [<phorge>/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php:153]

Closes T16006

Test Plan
  • Go to /token/give/PHID-TASK-someValidId/ and click one of the tokens, compare Phorge behavior before and after patch
  • Go to a task, in the sidebar, click "Award a Token" and "Rescind a Token": Still works as before

Diff Detail

Repository
rP Phorge
Branch
T16006TokenExcpt (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1764
Build 1764: arc lint + arc unit