Paths

Table of Contentst

Differential D25894

Hide "Audits" section in Email Preferences when uninstalled
Needs ReviewPublic
Actions

Authored by aklapper on Sat, Feb 22, 14:33.

Tags

None

Referenced Files

	F2997597: D25894.1740401097.diff
	Sun, Feb 23, 12:44

	F2995385: D25894.1740339842.diff
	Sat, Feb 22, 19:44

	F2995352: D25894.1740337597.diff
	Sat, Feb 22, 19:06

	F2995351: D25894.1740337569.diff
	Sat, Feb 22, 19:06

Subscribers

valerio.bozzolan

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16002: Hide "Audits" section in Email Preferences when Audit is uninstalled

Summary

PhabricatorEmailPreferencesSettingsPanel::getAllEditorsWithTags() queries for all classes extending PhabricatorApplicationTransactionEditor and having getMailTagsMap() to then pull their editor application class. Thus return the correct editor application class.
Followup to rP821708414e.

Closes T16002

Test Plan

Uninstall Audit on /applications/view/PhabricatorAuditApplication/
Check for Audits section on /settings/panel/emailpreferences/

Diff Detail

Repository

Branch

T16002audit (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1741
Build 1741: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, Feb 22, 14:33

Owners added a reviewer: O1: Blessed Committers.Sat, Feb 22, 14:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Feb 22, 14:33

Harbormaster completed remote builds in B1741: Diff 2693.Sat, Feb 22, 14:33

aklapper requested review of this revision.Sat, Feb 22, 14:33

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

2 lines

0%

Loading...

O1: Blessed Committers

Diff 2693

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...