Page MenuHomePhorge

Hide "Audits" section in Email Preferences when uninstalled
ClosedPublic

Authored by aklapper on Feb 22 2025, 14:33.

Details

Summary

PhabricatorEmailPreferencesSettingsPanel::getAllEditorsWithTags() queries for all classes extending PhabricatorApplicationTransactionEditor and having getMailTagsMap() to then pull their editor application class. Thus return the correct editor application class.
Followup to rP821708414e.

grep -r "('PhabricatorApplicationTransactionEditor'" . shows only a single result in the Phorge codebase (this PhutilClassMapQuery->setAncestorClass('PhabricatorApplicationTransactionEditor') call) so I assume there will be no unwanted side effects.

Closes T16002

Test Plan
  • Uninstall Audit on /applications/view/PhabricatorAuditApplication/
  • Check for Audits section on /settings/panel/emailpreferences/
  • Re-install Audit and try random actions on a commit like: Accept commit, Raise a concern, Change Project Tags, award token, Subscribe, Unsubscribe, Resign as Auditor, no regressions

Diff Detail

Repository
rP Phorge
Branch
T16002audit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1741
Build 1741: arc lint + arc unit