Paths

Table of Contentst

Differential D25864

Paste previous milestone's description text when creating a new milestone
Needs RevisionPublic
Actions

Authored by aklapper on Feb 5 2025, 12:16.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15991: When creating a new project milestone, insert the description of the previous milestone

Summary

In the Milestone creation form, by default paste the description text of the previous milestone, and add instructions to review and edit that text.
This increases consistency of descriptions across milestones by streamlining workflows a bit.

Closes T15991

Test Plan

Select "Create Next Milestone" in a project which already has a previous milestone with Description text set: See additional instructions above the Description field, plus the Description text from the previous milestone pre-filled in the Description field.
Select "Create Next Milestone" in a project which already has a previous milestone with no Description text: Code not triggered.
Create a milestone in a project which has no milestones yet: Code not triggered.
Create a subproject in a project which has no subprojects yet: Code not triggered.
Create a subproject in a project which has a previous subproject: Code not triggered.

Diff Detail

Repository

rP Phorge

Branch

T15991 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1772
Build 1772: arc lint + arc unit

Event Timeline

aklapper created this revision.Feb 5 2025, 12:16

Owners added a reviewer: O1: Blessed Committers.Feb 5 2025, 12:16

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 5 2025, 12:16

Harbormaster completed remote builds in B1681: Diff 2617.Feb 5 2025, 12:16

aklapper requested review of this revision.Feb 5 2025, 12:16

aklapper retitled this revision from Allow pasting previous milestone's description when creating a new milestone to Allow copying previous milestone's description when creating a new milestone.Feb 5 2025, 13:45

Uh. Nice.

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

If you say "uhm yes" maybe we can keep this patch stalled (and find some time to understand how to put some more object-oriented in PhabricatorEditEngine), and play a bit in another patch. So, if we are capable of the different thing, good, if not, we continue this, so at least you have something in WMF. What do you think about?

In D25864#23737, @valerio.bozzolan wrote:

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea?

Yes. One manual action less which needs to be done anyway.

That could be also probably done server-side, without JavaScript.

Very very likely. But I'm too stupid to find out how, so far.

If you say "uhm yes" maybe we can keep this patch stalled (and find some time to understand how to put some more object-oriented in PhabricatorEditEngine), and play a bit in another patch.

"Whatever makes me feel like there is some progress into the right direction", as I would probably reply to my manager at work. :P

Directly put the text of the previous milestone into the description field and display additional info about this new behavior. Less code complexity, less manual user actions.

Harbormaster completed remote builds in B1771: Diff 2731.Mar 8 2025, 13:11

Make funtion private now that it's all in the same class; fix a doc typo

Harbormaster completed remote builds in B1772: Diff 2732.Mar 8 2025, 13:13

aklapper retitled this revision from Allow copying previous milestone's description when creating a new milestone to Paste previous milestone's description text when creating a new milestone.Mar 8 2025, 13:17

aklapper edited the summary of this revision. (Show Details)

aklapper edited the test plan for this revision. (Show Details)

Super nice prototype but flagging as "more digging probably needed for production"

src/applications/project/engine/PhabricatorProjectEditEngine.php
143	Super nice prototype but this check, here, with `getLabel() === 'Description` is too much hacky. I wonder if we can avoid to patch the field here in this loop. Probably we can find the callers of `willConfigureFields($fields)` and find where this field is defined (?) even if not able to do 1, the label is not an identifier but a translation. The check does not work for other languages. We also should not adopt `getLabel() === phg('Description')` because it would be probably more correct but more hacky. Maybe better to afford point (1)

This revision now requires changes to proceed.Mon, Apr 28, 07:13

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

project/

engine/

PhabricatorProjectEditEngine.php

50 lines

64%

O1: Blessed Committers

Diff 2732

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

Paste previous milestone's description text when creating a new milestoneNeeds RevisionPublicActions