Paths

Table of Contentst

-
src/infrastructure/markup/remarkup/__tests__/remarkup/
-
infrastructure/
-
markup/
-
remarkup/
-
__tests__/
-
remarkup/
-
link-alternate.txt

Differential D25820

Fix unit test failure in link-alternate
ClosedPublic
Actions

Authored by aklapper on Sep 7 2024, 04:36.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPf25c531e5685: Fix unit test failure in link-alternate

Summary

arc unit --everything triggers a FAIL PhutilRemarkupEngineTestCase::testEngine due to adding the CSS class remarkup-link-ext in rP349f006904fabf1d4df31ff4840502af3ab379a7. Thus update it accordingly.

Test Plan

Run arc unit.

Diff Detail

Repository

rP Phorge

Branch

fixLinkAlternateTest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1584
Build 1584: arc lint + arc unit

Event Timeline

aklapper created this revision.Sep 7 2024, 04:36

Owners added a reviewer: O1: Blessed Committers.Sep 7 2024, 04:36

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 7 2024, 04:36

aklapper requested review of this revision.Sep 7 2024, 04:36

Harbormaster completed remote builds in B1584: Diff 2460.Sep 7 2024, 04:36

aklapper retitled this revision from Update unit test link-alternate to Fix unit test failure in link-alternate.Sep 7 2024, 07:35

Nice catch, thanks! Sorry for this regression in unit tests

This revision is now accepted and ready to land.Sep 7 2024, 08:08

Closed by commit rPf25c531e5685: Fix unit test failure in link-alternate. · Explain WhySep 7 2024, 09:00

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPf25c531e5685: Fix unit test failure in link-alternate.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

markup/

remarkup/

__tests__/

remarkup/

link-alternate.txt

2 lines

O1: Blessed Committers

Diff 2460

View Options

src/infrastructure/markup/remarkup/tests/remarkup/link-alternate.txt

Show All 30 Lines	if ($supported_formats) {
$supported_formats_message = pht('Supported image formats: %s.',		$supported_formats_message = pht('Supported image formats: %s.',
implode(', ', $supported_formats));		implode(', ', $supported_formats));
} else {		} else {
$supported_formats_message = pht('Server supports no image formats.');		$supported_formats_message = pht('Server supports no image formats.');
}		}
$e_file = true;		$e_file = true;
$errors = array();		$errors = array();

		$max_image_dimensions =
		PhabricatorFileImageTransform::getMaxTransformDimensions();
		$max_image_dimensions_message = pht('Maximum image dimensions: %s pixels.',
		implode(mb_chr(215), $max_image_dimensions));

if ($request->isFormPost()) {		if ($request->isFormPost()) {
$phid = $request->getStr('phid');		$phid = $request->getStr('phid');
$is_default = false;		$is_default = false;
if ($phid == PhabricatorPHIDConstants::PHID_VOID) {		if ($phid == PhabricatorPHIDConstants::PHID_VOID) {
$phid = null;		$phid = null;
$is_default = true;		$is_default = true;
} else if ($phid) {		} else if ($phid) {
$file = id(new PhabricatorFileQuery())		$file = id(new PhabricatorFileQuery())
▲ Show 20 Lines • Show All 202 Lines • ▼ Show 20 Lines	public function handleRequest(AphrontRequest $request) {
$upload_form = id(new AphrontFormView())		$upload_form = id(new AphrontFormView())
->setUser($viewer)		->setUser($viewer)
->setEncType('multipart/form-data')		->setEncType('multipart/form-data')
->appendChild(		->appendChild(
id(new AphrontFormFileControl())		id(new AphrontFormFileControl())
->setName('picture')		->setName('picture')
->setLabel(pht('Upload Picture'))		->setLabel(pht('Upload Picture'))
->setError($e_file)		->setError($e_file)
->setCaption($supported_formats_message))		->setCaption($supported_formats_message.' '.
		$max_image_dimensions_message))
->appendChild(		->appendChild(
id(new AphrontFormSubmitControl())		id(new AphrontFormSubmitControl())
->addCancelButton($done_uri)		->addCancelButton($done_uri)
->setValue(pht('Upload Picture')));		->setValue(pht('Upload Picture')));

$upload_box = id(new PHUIObjectBoxView())		$upload_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Upload New Picture'))		->setHeaderText(pht('Upload New Picture'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)		->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
Show All 28 Lines

Fix unit test failure in link-alternateClosedPublicActions