Page MenuHomePhorge
Differential D25807

Clarify comment in PhutilJSON about required PHP version
ClosedPublic
Actions

Authored by aklapper on Mon, Aug 26, 10:29.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rARC9f66bff5f663: Clarify comment in PhutilJSON about required PHP version
Summary

Future developers may want to clean up some code after bumping required versions, so explicitly state that JSON_UNESCAPED_SLASHES was introduced in PHP 5.4.0 and that the PHP JSON extension is a core PHP extension since PHP 8.0.0 and cannot be disabled anymore, to save time looking up stuff.

https://www.php.net/ChangeLog-5.php#5.4.0
https://www.php.net/manual/en/json.installation.php

Test Plan

Read the docs.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Aug 26, 10:29
Owners added a reviewer: O1: Blessed Committers.Mon, Aug 26, 10:29
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Aug 26, 10:29
aklapper requested review of this revision.Mon, Aug 26, 10:29
Harbormaster completed remote builds in B1567: Diff 2426.Mon, Aug 26, 10:29
valerio.bozzolan accepted this revision.Mon, Aug 26, 13:45

yesyes

This revision is now accepted and ready to land.Mon, Aug 26, 13:45
valerio.bozzolan added a comment.Mon, Aug 26, 14:25

P.S. try applying D25809 to check if the red unit test becomes green

This revision was landed with ongoing or failed builds.Mon, Aug 26, 14:36
Closed by commit rARC9f66bff5f663: Clarify comment in PhutilJSON about required PHP version. · Explain Why
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rARC9f66bff5f663: Clarify comment in PhutilJSON about required PHP version.
aklapper mentioned this in D25809: ArcanistBundleTestCase: fix support of non-English environments.Mon, Aug 26, 21:41
aklapper added a comment.Tue, Sep 10, 10:53
In D25807#21516, @valerio.bozzolan wrote:

P.S. try applying D25809 to check if the red unit test becomes green

@valerio.bozzolan: It won't - my locale has always been en_US.utf8 so "my" issue isn't localization related (and it seems not to allow me to test your patch, as it "covers" your issue)...

Revision Contents
Changeset List

PathSizePackages
src/
parser/
3 linesO1: Blessed Committers

Diff 2429

View Options

src/parser/PhutilJSON.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0