Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction
ClosedPublic

Authored by aklapper on Aug 5 2024, 11:43.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php:85]

Closes T15902

Test Plan

Unclear due to lack of steps to reproduce.

Diff Detail

Repository
rP Phorge
Branch
T15902strlenPoints
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1499
Build 1499: arc lint + arc unit