Page MenuHomePhorge
Differential D25703

Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field
ClosedPublic
Actions

Authored by jkimbo on Jun 27 2024, 09:58.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rARC0c9c94748b58: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty…
Summary

This revision fixes a trim(null) exception when creating a diff with an empty
field.

Fixes: T15868

Test Plan
  1. Create a commit with an empty "Differential Revision:" field
  2. Run arc diff

Diff Detail

Repository
rARC Arcanist
Branch
fix-trim-null-empty-fields
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1377
Build 1377: arc lint + arc unit

Event Timeline

jkimbo created this revision.Jun 27 2024, 09:58
jkimbo held this revision as a draft.
Owners added a reviewer: O1: Blessed Committers.Jun 27 2024, 09:58
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 27 2024, 09:58
Harbormaster completed remote builds in B1377: Diff 2163.Jun 27 2024, 09:58
jkimbo published this revision for review.Jun 27 2024, 09:59
avivey subscribed.Jun 27 2024, 10:36

maybe just add if ($value === null) { continue; } somewhere before the this?

valerio.bozzolan added a comment.Jun 27 2024, 10:38

somewhere before the this

Uhm. Where? 🤔

avivey added inline comments.Jun 27 2024, 10:39
src/workflow/ArcanistDiffWorkflow.php
1935

here-ish?

jkimbo updated this revision to Diff 2366.Aug 14 2024, 08:34

Move null check to earlier in function

Harbormaster completed remote builds in B1524: Diff 2366.Aug 14 2024, 08:34
jkimbo marked an inline comment as done.Aug 14 2024, 08:35

Sorry for the delay with this. I've moved the null check as suggested.

valerio.bozzolan accepted this revision.Aug 19 2024, 12:49

lgtm

Also without that comment in 1942. Feel free to omit. It's self-explaining.

This revision is now accepted and ready to land.Aug 19 2024, 12:49
jkimbo updated this revision to Diff 2410.Aug 22 2024, 14:32

Remove unecessary comment

Harbormaster completed remote builds in B1556: Diff 2410.Aug 22 2024, 14:32
Closed by commit rARC0c9c94748b58: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty…. · Explain WhyAug 22 2024, 14:33
This revision was automatically updated to reflect the committed changes.
Restricted Repository Identity added a commit: rARC0c9c94748b58: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty….

Revision Contents
Changeset List

PathSizePackages
src/
workflow/
2 linesO1: Blessed Committers

Diff 2163

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0