Page MenuHomePhorge

Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed
ClosedPublic

Authored by aklapper on Jun 7 2024, 16:53.

Details

Summary

https://we.phorge.it/source/phorge/browse/master/src/view/page/PhabricatorStandardPageView.php$908 tries to "find some navigational menu items to create a mobile navigation menu from" but does not succeed too much it seems:
On a user profile page, that very code calls buildApplicationMenu() in PhabricatorPeopleController which calls buildSideNavView() in the same class.
This code unconditionally displays a "Calendar" menu item, no matter if the Calendar application is installed or not. Thus check first to avoid offering a link ending up in a 404.

For the time being this change renders the menu empty (apart from a link to the page we are already on) but that's more acceptable than all those tears shed by devastated users after clicking the Calendar menu item while being excited and full of anticipation, just to end up on a 404 page instead.

Related: T15224

Test Plan

Diff Detail

Repository
rP Phorge
Branch
peopleMenuMobileCal (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1333
Build 1333: arc lint + arc unit