Page MenuHomePhorge
Differential D25665

PHPMailer: Remove unused variable
ClosedPublic
Actions

Authored by aklapper on May 20 2024, 08:39.
Tags
None
Referenced Files
F3938792: D25665.1746428596.diff
Sun, May 4, 07:03
F3925914: D25665.1746366844.diff
Sat, May 3, 13:54
F3908546: D25665.1746335088.diff
Sat, May 3, 05:04
F3890648: D25665.1746271572.diff
Fri, May 2, 11:26
F3852690: D25665.1746129531.diff
Wed, Apr 30, 19:58
F3838559: D25665.1746097002.diff
Wed, Apr 30, 10:56
F3749247: D25665.1745794174.diff
Sat, Apr 26, 22:49
F3645278: D25665.1745367632.diff
Tue, Apr 22, 00:20
View All 56 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP40b1e6b17acc: PHPMailer: Remove unused variable
Summary

$tmp is declared but never used.

Test Plan

Read/grep the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 2049

View Options

externals/phpmailer/class.phpmailer-lite.php

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/usr/bin/env php
<?php
$arcanist_root = dirname(dirname(dirname(dirname(__FILE__))));
require_once $arcanist_root.'/support/init/init-script.php';
valerio.bozzolanUnsubmitted
Done
Inline Actions

Very probably there is no need for these 2 lines in this script. Maybe better to comment to reduce loaded resources.

valerio.bozzolan: Very probably there is no need for these 2 lines in this script. Maybe better to comment to…
$cppflags = '';
$arch =php_uname('m');
if ($arch == 'i386' || $arch == 'x86_64') {
$cppflags += ' -minline-all-stringops ';
valerio.bozzolanUnsubmitted
Done
Inline Actions
if ($arch == 'i386' || $arch == 'x86_64') {
- $cppflags += ' -minline-all-stringops ';
+ $cppflags .= ' -minline-all-stringops ';
}
echo $cppflags;

Ops wait. Please don't sum in PHP. Use the concatenate operator with dot.

Otherwise in recent PHP versions this can throw an error

valerio.bozzolan: Ops wait. Please don't sum in PHP. Use the concatenate operator with dot. Otherwise in recent…
}
echo $cppflags;
echo "\n";
View Options

externals/phpmailer/class.phpmailer.php

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/usr/bin/env php
<?php
$arcanist_root = dirname(dirname(dirname(dirname(__FILE__))));
require_once $arcanist_root.'/support/init/init-script.php';
valerio.bozzolanUnsubmitted
Done
Inline Actions

Very probably there is no need for these 2 lines in this script. Maybe better to comment to reduce loaded resources.

valerio.bozzolan: Very probably there is no need for these 2 lines in this script. Maybe better to comment to…
$cppflags = '';
$arch =php_uname('m');
if ($arch == 'i386' || $arch == 'x86_64') {
$cppflags += ' -minline-all-stringops ';
valerio.bozzolanUnsubmitted
Done
Inline Actions
if ($arch == 'i386' || $arch == 'x86_64') {
- $cppflags += ' -minline-all-stringops ';
+ $cppflags .= ' -minline-all-stringops ';
}
echo $cppflags;

Ops wait. Please don't sum in PHP. Use the concatenate operator with dot.

Otherwise in recent PHP versions this can throw an error

valerio.bozzolan: Ops wait. Please don't sum in PHP. Use the concatenate operator with dot. Otherwise in recent…
}
echo $cppflags;
echo "\n";
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0