Page MenuHomePhorge

Fix typo creating QRbitstream()
ClosedPublic

Authored by aklapper on May 16 2024, 15:15.

Details

Summary

Make the one new QRbitrtream() look like the other nine new QRbitstream().

Interestingly, this bug was reported upstream since 2018, and still not fixed:

https://github.com/t0k4rt/phpqrcode/issues/47

Test Plan

Read the code aloud and realize that this word sound weird.

Verify that the class QRbitrtream does not exist, and QRbitstream exists.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25651
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1287
Build 1287: arc lint + arc unit

Event Timeline

It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

Interestingly, this bug was reported upstream since 2018, and never fixed:

https://github.com/t0k4rt/phpqrcode/issues/47

Let's see if they will ever merge:

https://github.com/t0k4rt/phpqrcode/pull/58

This revision is now accepted and ready to land.May 18 2024, 19:26
valerio.bozzolan edited the test plan for this revision. (Show Details)

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

This revision was automatically updated to reflect the committed changes.