Differential D25609

Reports: Remove unused variable
ClosedPublic
Actions

Authored by aklapper on Apr 30 2024, 16:22.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP74e28bc2a7b0: Reports: Remove unused variable

Summary

This variable feels unneeded in this function. It may have a better and more fulfilling life after finding a new function.

Test Plan

Read slowly and aloud all code in the function.

Diff Detail

Repository

rP Phorge

Branch

reportsUnsedVar (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1209
Build 1209: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 30 2024, 16:22

Owners added a reviewer: O1: Blessed Committers.Apr 30 2024, 16:22

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 30 2024, 16:22

aklapper requested review of this revision.Apr 30 2024, 16:22

Harbormaster completed remote builds in B1209: Diff 1914.Apr 30 2024, 16:22

Phorge saves CPU cycles

This revision is now accepted and ready to land.Apr 30 2024, 18:57

Closed by commit rP74e28bc2a7b0: Reports: Remove unused variable. · Explain WhyMay 1 2024, 09:44

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP74e28bc2a7b0: Reports: Remove unused variable.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

project/

controller/

PhabricatorProjectReportsController.php

5 lines

O1: Blessed Committers

Diff 1914

View Options

src/applications/project/controller/PhabricatorProjectReportsController.php

Reports: Remove unused variableClosedPublicActions