Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 23:05.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementEncodeWorkflow.php:45]
Test Plan

Run ../phorge/bin/files encode F1: Get no strlen() error anymore but only expected output Usage Exception: Use --as <format> to select a target encoding format. Available formats are: aes-256-cbc, rot13, raw.

Diff Detail

Repository
rP Phorge
Branch
cliFilesEncodeStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1187
Build 1187: arc lint + arc unit