Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:57.
Tags
None
Referenced Files
F2198275: D25589.1716330340.diff
Mon, May 20, 22:25
F2198121: D25589.1716316476.diff
Mon, May 20, 18:34
Unknown Object (File)
Sun, Apr 28, 02:00
Unknown Object (File)
Sat, Apr 27, 19:53
Unknown Object (File)
Sat, Apr 27, 10:13
Unknown Object (File)
Sat, Apr 27, 07:36
Unknown Object (File)
Fri, Apr 26, 20:12
Unknown Object (File)
Thu, Apr 25, 04:46

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php:24]
Test Plan

Run ../phorge/bin/search query: Get no strlen() error anymore but only expected output Usage Exception: Specify a query with --query.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable