Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 08:15.
Tags
None
Referenced Files
F2193460: D25579.1715992674.diff
Fri, May 17, 00:37
Unknown Object (File)
Wed, May 15, 02:13
Unknown Object (File)
Mon, May 13, 18:07
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Sat, May 4, 18:55
Unknown Object (File)
Sat, May 4, 13:01
Unknown Object (File)
Sat, Apr 27, 23:48

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementGenerateKeyWorkflow.php:23]
Test Plan

Run ../phorge/bin/files generate-key: Get no strlen() error anymore but only expected output Usage Exception: Specify the type of key to generate with --type.

Diff Detail

Repository
rP Phorge
Branch
cliFilesStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1171
Build 1171: arc lint + arc unit