Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

In D25488#14099, @aklapper wrote:

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

Yes, we can do that also in line 14

To reproduce the crash there, I visited the page

/config/edit/maniphest.custom-field-definitions/

And I've added this custom field with search enabled:

{
  "megalol:favorite-dinosaur": {
    "name": "Favorite Dinosaur",
    "type": "text",
    "search": true
  }
}

I can sticky-accept the change. Feel free to update line 14 and land (no need to re-approve again here).