Page MenuHomePhorge

Fix answer background color when using Dark Mode in Ponder
ClosedPublic

Authored by bob on Aug 16 2023, 09:37.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 21:46
Unknown Object (File)
Thu, May 2, 14:45
Unknown Object (File)
Wed, May 1, 19:14
Unknown Object (File)
Wed, May 1, 19:14
Unknown Object (File)
Tue, Apr 30, 18:41
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Wed, Apr 24, 21:50
Unknown Object (File)
Apr 11 2024, 02:54

Details

Summary

This CSS fix replaces the hard coded white background value by the page.content CSS variable.

BeforeAfter
screenshot-phorge-bug-darkmode-ponder-answer-before.png (434×1 px, 23 KB)
screenshot-phorge-bug-darkmode-ponder-answer-after.png (434×1 px, 26 KB)
Test Plan
  • Flush all Phorge caches
  • Sign in
  • Go to question with at least one answer.
  • Check that the answer block background color is consistent with the theme.
  • Do these steps for each user interface theme in order to check against regression.

Diff Detail

Repository
rP Phorge
Branch
css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 759
Build 759: arc lint + arc unit

Event Timeline

bob requested review of this revision.Aug 16 2023, 09:37

You are a good minion, thanks bob

Tested with and without Dark Mode enabled

I confirm that Celerity map was already up to date \o/

sgtm

This revision is now accepted and ready to land.Aug 19 2023, 03:52