Fix call to undefined method PhutilJSON::encodeAsObject()
ClosedPublic
Actions

Authored by aklapper on Aug 14 2023, 20:56.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15603: Exception: Call to undefined method PhutilJSON::encodeAsObject()

Commits

rP68c687affdca: Fix call to undefined method PhutilJSON::encodeAsObject()

Summary

Replace call to undefined method PhutilJSON::encodeAsObject() with existing PhutilJSON::encodeFormatted()

EXCEPTION: (Error) Call to undefined method PhutilJSON::encodeAsObject() at [<phabricator>/src/applications/transactions/xaction/PhabricatorEditEngineDefaultTransaction.php:68]

Closes T15603

Test Plan

Grep and read the code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilJSON.php

Diff Detail

Repository

rP Phorge

Branch

T15603 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 753
Build 753: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 14 2023, 20:56

Owners added a reviewer: O1: Blessed Committers.Aug 14 2023, 20:56

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 14 2023, 20:56

aklapper requested review of this revision.Aug 14 2023, 20:56

Harbormaster completed remote builds in B753: Diff 1253.Aug 14 2023, 20:56

Thanks for this. I need a double-check since I'm quite scared by the background of this root problem but fortunately this seems to have just one occurrence, the one you are fixing.

The origin seems this:

https://secure.phabricator.com/D20595

And this in particular:

https://secure.phabricator.com/D20594

Also let's verify XSS and this kind of stuff

Thanks for this change that looks absolutely reasonable.

Please wait a $random_amount_of_time (more than 1 second and less than 1 month) before landing this so we can attract more professssssssional opinions

This revision is now accepted and ready to land.Aug 15 2023, 07:30

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Closed by commit rP68c687affdca: Fix call to undefined method PhutilJSON::encodeAsObject(). · Explain WhySep 2 2023, 09:13

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP68c687affdca: Fix call to undefined method PhutilJSON::encodeAsObject().