Paths

Table of Contentst

Differential D25260

Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database Status page
ClosedPublic
Actions

Authored by aklapper on May 29 2023, 17:45.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15428: PHP 8.1 "strlen(null)" exception blocks rendering Config's Database Status page

Commits

rP7cf210b76385: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15428

Test Plan

Applied this change; afterwards displays "Database Status" page at /config/database/ correctly rendered in web browser.

Also visit every single database name, to see that also there nothing explode.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.May 29 2023, 17:45

Owners added a reviewer: O1: Blessed Committers.May 29 2023, 17:45

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 29 2023, 17:45

Harbormaster completed remote builds in B479: Diff 838.May 29 2023, 17:45

aklapper requested review of this revision.May 29 2023, 17:45

Thanks, again! :)

I verified this patch locally with MariaDB

The $property just assumes values like null or strings like "phabricator_user" or "phabricator_legalpad" etc.

The function phutil_nonempty_string() will explode with any alien type, and that is OK here.

I've opened all the single pages, one per database, (more than 60 databases) without any crash.

sgtm

This revision is now accepted and ready to land.May 29 2023, 19:11

valerio.bozzolan edited the test plan for this revision. (Show Details)May 29 2023, 19:11

Closed by commit rP7cf210b76385: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database…. · Explain WhyMay 30 2023, 08:59

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP7cf210b76385: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

config/

controller/

services/

PhabricatorConfigDatabaseStatusController.php

2 lines

O1: Blessed Committers

Diff 846

View Options

src/applications/config/controller/services/PhabricatorConfigDatabaseStatusController.php

Fix PHP 8.1 "strlen(null)" exception which blocks rendering Config's Database Status pageClosedPublicActions