Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Aug 22 2024

jkimbo updated the diff for D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

Remove unecessary comment

Aug 22 2024, 14:32

Aug 14 2024

jkimbo added a comment to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

Sorry for the delay with this. I've moved the null check as suggested.

Aug 14 2024, 08:35

jkimbo updated the diff for D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

Move null check to earlier in function

Aug 14 2024, 08:34

Jun 27 2024

jkimbo published D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field for review.

Jun 27 2024, 09:59

jkimbo created T15868: PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

Jun 27 2024, 09:56

May 27 2023

jkimbo added Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch (Answer 70).

May 27 2023, 16:07

May 24 2023

jkimbo added a comment to D25237: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

Awesome, revision landed. Thanks for the help @valerio.bozzolan

May 24 2023, 19:07

May 23 2023

jkimbo added a comment to D25237: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

@valerio.bozzolan I'm not familiar with the process here, is it up to me to land the revision or do I wait until a maintainer does it?

May 23 2023, 19:19

valerio.bozzolan awarded D25237: Correct a PHP8 compatibility issue when running "arc diff" with no active branch a Love token.

May 23 2023, 12:53

jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Created T15412 and D25237 to fix this issue.

May 23 2023, 12:46 · Arcanist

jkimbo requested review of D25237: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

May 23 2023, 12:45

jkimbo added a revision to T15412: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch: D25237: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

May 23 2023, 12:45 · PHP 8 support

jkimbo created T15412: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

May 23 2023, 12:38 · PHP 8 support

jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

Thanks!

May 23 2023, 12:38 · Arcanist

jkimbo added a comment to Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

@valerio.bozzolan have you added me to the Trusted Contributors group? I don't seem to have the permission to create any new tasks. Happy to create the task for this bug and the diff to fix it.

May 23 2023, 08:40 · Arcanist

May 22 2023

valerio.bozzolan awarded Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch a Like token.

May 22 2023, 20:06 · Arcanist

jkimbo asked Q57: PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch.

May 22 2023, 10:40 · Arcanist