Paths

Table of Contentst

Fix return value of ArcanistWeldWorkflow::runWorkflow()
ClosedPublic
Actions

Authored by aklapper on Sun, Jun 15, 10:42.

Details

Reviewers

mainframe98
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC95adc3462f5c: Fix return value of ArcanistWeldWorkflow::runWorkflow()

Summary

ArcanistWeldWorkflow::runWorkflow() is supposed to return an int like all other implementations of ArcanistWorkflow::runWorkflow() already do.

Test Plan

Run static code analysis, don't get a complaint about a missing return value anymore.

Diff Detail

Repository

rARC Arcanist

Branch

workflowReturnInt (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2118
Build 2118: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Jun 15, 10:42

Owners added a reviewer: O1: Blessed Committers.Sun, Jun 15, 10:42

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Jun 15, 10:42

aklapper requested review of this revision.Sun, Jun 15, 10:42

Harbormaster completed remote builds in B2113: Diff 3242.Sun, Jun 15, 10:42

mainframe98 requested changes to this revision.Sun, Jun 15, 12:07

mainframe98 subscribed.

mainframe98 added inline comments.

src/workflow/ArcanistWeldWorkflow.php
72–74	Implode returns a string, not an int. Also, `arc weld` reports the results to stdout, which requires using `echo`.

This revision now requires changes to proceed.Sun, Jun 15, 12:07

Thanks. Learned something about arc weld which I obviously have never used before (and hadn't realized that this is actually a command itself).

Harbormaster completed remote builds in B2118: Diff 3249.Sun, Jun 15, 19:29

aklapper marked an inline comment as done.Sun, Jun 15, 19:29

valerio.bozzolan edited the summary of this revision. (Show Details)Sun, Jun 15, 19:56

mainframe98 accepted this revision.Sun, Jun 15, 19:56

This revision is now accepted and ready to land.Sun, Jun 15, 19:56

Fantastic. We have a cat but in PHP. And it returns random data.

arc weld README.md README.md

Stay sure that you will always get random output, before and output the patch.

Closed by commit rARC95adc3462f5c: Fix return value of ArcanistWeldWorkflow::runWorkflow(). · Explain WhyMon, Jun 16, 09:40

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC95adc3462f5c: Fix return value of ArcanistWeldWorkflow::runWorkflow().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

workflow/

ArcanistWeldWorkflow.php

2 lines

O1: Blessed Committers

Diff 3249

View Options

src/workflow/ArcanistWeldWorkflow.php

Fix return value of ArcanistWeldWorkflow::runWorkflow()ClosedPublicActions