Differential D26085

Fix some invalid PhpDoc
ClosedPublic
Actions

Authored by aklapper on Sat, Jun 14, 17:02.

Tags

None

Referenced Files

	F5490872: D26085.1750128413.diff
	Mon, Jun 16, 02:46

	F5490674: D26085.1750128040.diff
	Mon, Jun 16, 02:40

	F5490539: D26085.1750127837.diff
	Mon, Jun 16, 02:37

	F5488285: D26085.1750124044.diff
	Mon, Jun 16, 01:34

	F5487928: D26085.1750123460.diff
	Mon, Jun 16, 01:24

	F5486326: D26085.1750120817.diff
	Mon, Jun 16, 00:40

	F5486278: D26085.1750120714.diff
	Mon, Jun 16, 00:38

	F5483997: D26085.1750116810.diff
	Sun, Jun 15, 23:33

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Commits

rARC8f2bc3929bae: Fix some invalid PhpDoc

Summary

Fix invalid syntax etc.

Test Plan

Compare PHPDoc and signature; see rARC3df48c9257c3abe0856eacb81d480ab639208fb5 for changes in ExecFuture.

Diff Detail

Repository

Branch

phpdocinvalid (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 2103
Build 2103: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	237 ms	ArcanistXMLLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "languages-6.lint-test". MISSING MESSAGES Message with severity "error" at "4:1" (XML5)
	183 ms	ArcanistChmodLinterTestCase::testLinter 5 assertion(s) passed.
	162 ms	ArcanistClosureLinterTestCase::testVersion 1 assertion(s) passed.
	165 ms	ArcanistCpplintLinterTestCase::testVersion 1 assertion(s) passed.
	188 ms	ArcanistFilenameLinterTestCase::testLinter 5 assertion(s) passed.
		View Full Test Results (1 Failed · 39 Passed · 31 Skipped)

Event Timeline

aklapper created this revision.Sat, Jun 14, 17:02

Owners added a reviewer: O1: Blessed Committers.Sat, Jun 14, 17:02

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Jun 14, 17:02

aklapper requested review of this revision.Sat, Jun 14, 17:02

Harbormaster completed remote builds in B2103: Diff 3229.Sat, Jun 14, 17:02

mainframe98 subscribed.Sat, Jun 14, 17:09

mainframe98 added inline comments.

src/console/PhutilConsoleServer.php
102

...as mainframe98 says

Harbormaster completed remote builds in B2104: Diff 3230.Sat, Jun 14, 17:13

aklapper marked an inline comment as done.Sat, Jun 14, 17:14

Strange. The failing unit test succeeds on my machine, even with this change checked out.

This revision is now accepted and ready to land.Sat, Jun 14, 17:16

oh well, this should work better

Harbormaster completed remote builds in B2105: Diff 3231.Sat, Jun 14, 17:40

See T16098 for the unit test

This revision was landed with ongoing or failed builds.Sun, Jun 15, 09:05

Closed by commit rARC8f2bc3929bae: Fix some invalid PhpDoc. · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC8f2bc3929bae: Fix some invalid PhpDoc.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

console/

PhutilConsoleServer.php

2 lines

10%

Loading...

O1: Blessed Committers

future/

exec/

13 lines

64%

Loading...

O1: Blessed Committers

hgdaemon/

ArcanistHgProxyClient.php

2 lines

3%

Loading...

O1: Blessed Committers

lint/

engine/

ArcanistLintEngine.php

4 lines

63%

Loading...

O1: Blessed Committers

linter/

ArcanistExternalLinter.php

2 lines

32%

Loading...

O1: Blessed Committers

workflow/

ArcanistWorkflow.php

2 lines

0%

Loading...

O1: Blessed Committers

Diff 3229

src/console/PhutilConsoleServer.php

Loading...

src/future/exec/ExecFuture.php

Loading...

src/hgdaemon/ArcanistHgProxyClient.php

Loading...

src/lint/engine/ArcanistLintEngine.php

Loading...

src/lint/linter/ArcanistExternalLinter.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...