Paths

Table of Contentst

Differential D26066

PHPDoc: Replace non-existing return type tuple with array
AcceptedPublic
Actions

Authored by aklapper on Thu, Jun 5, 12:15.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

tuple is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

phpdocKillTupleType (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2065
Build 2065: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, Jun 5, 12:15

Owners added a reviewer: O1: Blessed Committers.Thu, Jun 5, 12:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Jun 5, 12:15

aklapper requested review of this revision.Thu, Jun 5, 12:15

Harbormaster completed remote builds in B2065: Diff 3162.Thu, Jun 5, 12:15

Sorry tuples

This revision is now accepted and ready to land.Fri, Jun 6, 15:23

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

2 lines

54%

O1: Blessed Committers

infrastructure/

daemon/

workers/

PhabricatorWorker.php

2 lines

36%

O1: Blessed Committers

Diff 3162

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

PHPDoc: Replace non-existing return type tuple with arrayAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3162

src/applications/differential/parser/DifferentialChangesetParser.php

src/infrastructure/daemon/workers/PhabricatorWorker.php

PHPDoc: Replace non-existing return type tuple with array
AcceptedPublic
Actions

Revision Contents
Changeset List