PHPDoc: Replace non-existing return type markup with string
AcceptedPublic
Actions

Authored by aklapper on Thu, Jun 5, 11:59.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

markup is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

phpdocMarkup (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2063
Build 2063: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, Jun 5, 11:59

Owners added a reviewer: O1: Blessed Committers.Thu, Jun 5, 11:59

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Jun 5, 11:59

aklapper requested review of this revision.Thu, Jun 5, 11:59

Harbormaster completed remote builds in B2063: Diff 3160.Thu, Jun 5, 11:59

Sorry markup

This revision is now accepted and ready to land.Fri, Jun 6, 15:23

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

differential/

render/

DifferentialChangesetHTMLRenderer.php

4 lines

O1: Blessed Committers

Diff 3160

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

PHPDoc: Replace non-existing return type markup with stringAcceptedPublicActions