Paths

Table of Contentst

Differential D26036

Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php
Needs ReviewPublic
Actions

Authored by aklapper on Thu, May 29, 21:33.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set

Summary

Passing null to preg_replace() is deprecated behavior since PHP 8.1.
Thus check if $repository->getRepositorySlug() is set before passing that to escapeToken().

ERROR 8192: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283]

Closes T15824

Test Plan

Unknown.

Diff Detail

Repository

Branch

T15824secondtry (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2024
Build 2024: arc lint + arc unit

Event Timeline

aklapper created this revision.Thu, May 29, 21:33

Owners added a reviewer: O1: Blessed Committers.Thu, May 29, 21:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 29, 21:33

aklapper requested review of this revision.Thu, May 29, 21:33

Harbormaster completed remote builds in B2024: Diff 3114.Thu, May 29, 21:33

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

infrastructure/

editor/

PhabricatorEditorURIEngine.php

4 lines

63%

Loading...

O1: Blessed Committers

Diff 3114

src/infrastructure/editor/PhabricatorEditorURIEngine.php

Loading...