Page MenuHomePhorge

Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject()
ClosedPublic

Authored by aklapper on Mon, May 19, 17:46.
Tags
None
Referenced Files
F4319343: D26025.1748134026.diff
Sat, May 24, 00:47
F4319309: D26025.1748133395.diff
Sat, May 24, 00:36
F4319276: D26025.1748133111.diff
Sat, May 24, 00:31
F4318698: D26025.1748124952.diff
Fri, May 23, 22:15
F4318609: D26025.1748123456.diff
Fri, May 23, 21:50
F4317825: D26025.1748112326.diff
Fri, May 23, 18:45
F4317171: D26025.1748103179.diff
Fri, May 23, 16:12
F4316819: D26025.1748097965.diff
Fri, May 23, 14:46

Details

Summary

All implementations of canLoadNamedObject($name) in classes which extend PhabricatorPHIDType run a preg_match() on the $name parameter being passed.
Thus the parameter must always be a string.
(Spoiler: This isn't always the case currently.)

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Branch
phpdocCanLoadNamedObject (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1994
Build 1994: arc lint + arc unit