Page MenuHomePhorge

Catch exception when a renderer freaks out
AcceptedPublic

Authored by avivey on Fri, May 2, 10:07.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Summary

Had some cases where the Py-Notebook(?) renderer throws an exception in can render, blocking the entire page render.
"False" is probably the right answer if you crash here.

Test Plan

Loaded same file, saw some meta-data about the file.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1912
Build 1912: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Fri, May 2, 10:07

Should we phlog($e) in your opinion?

Should we phlog($e) in your opinion?

Yeah, probably. The underlying exception should be handled eventually.

sgtm

src/applications/files/document/PhabricatorDocumentEngine.php
34
This revision is now accepted and ready to land.Fri, May 2, 15:56