Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed()
ClosedPublic
Actions

Authored by aklapper on Jul 27 2024, 11:21.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPee9991d3c995: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed()

Summary

The method HarbormasterBuildMessageRestartTransaction::isFailed() does not exist.

While there is a variety of classes that offer a public isFailed() method (HarbormasterBuildStatus, HarbormasterBuildableStatus, HarbormasterBuild, HarbormasterBuildTarget) which could have been meant instead (the git history provides no hints as this code has always been broken), the error message explicitly refers to a Build. Thus replace !$this->isFailed() with !$build->isFailed().

Test Plan

Run static code analysis; Read/grep the code.

Also, have a repository with at least an already-working Harbormaster Build Plan, and enable the option Restartable = "If Failed", and try to restart a failed build. After the patch it does not crash anymore.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 27 2024, 11:21

Owners added a reviewer: O1: Blessed Committers.Jul 27 2024, 11:21

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 27 2024, 11:21

aklapper requested review of this revision.Jul 27 2024, 11:21

Harbormaster completed remote builds in B1461: Diff 2279.Jul 27 2024, 11:21

Cigaryno added a project: Almanac/Drydock/Harbormaster.Dec 29 2024, 16:44

Tested in my production 🤩 fail before, works after, thanks lol

This revision is now accepted and ready to land.Thu, May 1, 22:27

valerio.bozzolan edited the test plan for this revision. (Show Details)Thu, May 1, 22:29

I am excited to announce that I personally watched @valerio.bozzolan crash Harbormaster's build and then load this awesome code into his PC computer machine and then repeat Harbormaster's build and then Harbormaster's build did not crash anymore. Therefore we decided that this awesome code is very good and as a courtesy to every Harbormaster out there will be made available for free, without any charge.

Closed by commit rPee9991d3c995: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed(). · Explain WhyThu, May 1, 22:56

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPee9991d3c995: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed().

aklapper added a project: Wikimedia Hackathon 2025.Thu, May 1, 22:57

valerio.bozzolan mentioned this in 2025.18.Sat, May 3, 22:42