Include number of modified files in total of attached files
ClosedPublic
Actions

Authored by aklapper on Feb 21 2025, 12:43.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15959: Modified files not counted in total when attaching files

Commits

rP44c7bfb42ddf: Include number of modified files in total of attached files

Summary

The second parameter in the message %s updated %s attached file(s), added %s: %s; removed %s: %s; modified %s: %s. did not take the number of modified files into account but only added and removed files.

Closes T15959

Test Plan

Read the code.
Additionally, update and remove and modify files attached to a task and count.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Feb 21 2025, 12:43

Owners added a reviewer: O1: Blessed Committers.Feb 21 2025, 12:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 21 2025, 12:43

aklapper requested review of this revision.Feb 21 2025, 12:43

Harbormaster completed remote builds in B1738: Diff 2689.Feb 21 2025, 12:43

Oh boy. D25893 first, I guess.

git rebase master; ./bin/celerity map; shows no output

Harbormaster completed remote builds in B1740: Diff 2692.Feb 21 2025, 13:34

Yuuum. As I mentioned downstream ( https://phabricator.wikimedia.org/T380361#10778444 ) I think probably, fortunately, nobody noticed this in a real world, since it's complicated to cause this condition using the API, and probably impossible from the web interface, but this still seems somehow a reasonable workflow and not dead code and the change makes sense. Thaaaanks

This revision is now accepted and ready to land.Tue, Apr 29, 21:22

Closed by commit rP44c7bfb42ddf: Include number of modified files in total of attached files. · Explain WhyWed, Apr 30, 06:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP44c7bfb42ddf: Include number of modified files in total of attached files.