Remove or correct wrong @return types in PHPDoc and/or correct wrong return values in methods.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rPc51002398d63: Fix invalid return values for void
Run static code analysis; read code; check method in parent class and other callers, etc.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- returnVoid (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1907 Build 1907: arc lint + arc unit
Event Timeline
| src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php | ||
|---|---|---|
| 36–37 | At this point this return can be dropped, with an evil laugh | |
| src/applications/search/query/PhabricatorSearchDocumentQuery.php | ||
| 107–108 | At this point this return can be dropped, with an evil laugh ✅ P.S. I verified that nothing calls ->nextPage()->something() | |
| src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php | ||
| 76–77 | At this point this return can be dropped, with an evil laugh | |
