Page MenuHomePhorge

Do not create search_documentfield table; update docs
ClosedPublic

Authored by aklapper on Feb 25 2025, 12:59.

Details

Summary

Per rP719dd6d3f44245e935b21291a59338a819938c49 and previous rP6cedd4a95cfc23a1679400fb64863c49f24f2306, remove the search_documentfield table from initial creation (quickstart.sql) and Diviner database docs.

Pointed out in Q82.

Additional context:
MySQL 5.6.4 released 2011-12-20 "now supports FULLTEXT indexes for InnoDB tables" per https://forums.mysql.com/read.php?3,506409 and per https://downloads.mysql.com/docs/mysql-5.6-relnotes-en.pdf pages 230 and 233.
Per https://www.oracle.com/us/support/library/lifetime-support-technology-069183.pdf page 29, "Extended Support Ends" for "MySQL Database 5.6" in "Feb 2021".
MariaDB went for version 10 instead of 5.6 per https://mariadb.org/mariadb-10-0-and-mysql-5-6/; MariaDB 10.0 saw its End of Life date on "31 Mar 2019" per https://mariadb.org/about/#maintenance-policy

Test Plan
  • As an admin, go to /config/issue/ which triggers PhabricatorSetupCheck::runNormalChecks() and thus runs database checks.
  • Install a fresh instance of Phorge which runs quickstart.sql, for example setting "storage.default-namespace": "test" inside conf/local/local.json and see that things still works, like Phriction search by name etc.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mainframe98 subscribed.

Ran ./bin/storage upgrade --namespace phabricator_quickstart_test2, and that didn't fail.

(Also I compared it against a freshly generated quickstart.sql in D25899: Rebuild quickstart.sql, where it doesn't show up either)

valerio.bozzolan edited the test plan for this revision. (Show Details)

Tested on a fresh install!

sgtm

This revision is now accepted and ready to land.Thu, Apr 24, 10:32