Page MenuHomePhorge
Differential D25964

Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
ClosedPublic
Actions

Authored by aklapper on Mon, Apr 14, 12:18.
Tags
None
Referenced Files
F3529124: D25964.1744861705.diff
Wed, Apr 16, 03:48
F3528469: D25964.1744852497.diff
Wed, Apr 16, 01:14
F3528452: D25964.1744850623.diff
Wed, Apr 16, 00:43
F3528444: D25964.1744850293.diff
Wed, Apr 16, 00:38
F3528424: D25964.1744850263.diff
Wed, Apr 16, 00:37
F3528138: D25964.1744847372.diff
Tue, Apr 15, 23:49
F3527851: D25964.1744844951.diff
Tue, Apr 15, 23:09
F3527734: D25964.1744842737.diff
Tue, Apr 15, 22:32
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery
Commits
rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
Summary

DiffusionCommitQuery passed duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery, making logs slightly more noisy.
Thus run array_unique() before passing.

Closes T16032

Test Plan

Go to http://phorge.localhost/diffusion/commit/query/all/ and look at SQL query in Dark Console before and after applying patch.

Diff Detail

Repository
rP Phorge
Branch
T16032 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1870
Build 1870: arc lint + arc unit

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
applications/
diffusion/
query/
4 lines0%
Loading...
O1: Blessed Committers

Diff 2881

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0