Paths

Table of Contentst

PHPDoc: Correct marker in one class header
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 8, 16:07.

Tags

None

Referenced Files

	F3852760: D25954.1746134364.diff
	Wed, Apr 30, 21:19

	F3847317: D25954.1746106107.diff
	Wed, Apr 30, 13:28

	F3833959: D25954.1746082637.diff
	Wed, Apr 30, 06:57

	F3818414: D25954.1746016457.diff
	Tue, Apr 29, 12:34

	F3803423: D25954.1745983028.diff
	Tue, Apr 29, 03:17

	F3702489: D25954.1745627092.diff
	Fri, Apr 25, 00:24

	F3681945: D25954.1745564126.diff
	Thu, Apr 24, 06:55

	F3607660: D25954.1745290952.diff
	Mon, Apr 21, 03:02

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP6a0e70d7163c: PHPDoc: Correct marker in one class header

Summary

This is PHPDoc for a class header. Thus there is no @param to pass.
Phorge specific @task info was meant here. See other examples in classes.

Test Plan

Read and grep the code.

Diff Detail

Repository

rP Phorge

Branch

PhpDocParamInfo (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1851
Build 1851: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Apr 8, 16:07

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 8, 16:07

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 8, 16:07

aklapper requested review of this revision.Tue, Apr 8, 16:07

Harbormaster completed remote builds in B1851: Diff 2850.Tue, Apr 8, 16:07

yesyes

This revision is now accepted and ready to land.Wed, Apr 23, 13:03

Closed by commit rP6a0e70d7163c: PHPDoc: Correct marker in one class header. · Explain WhyWed, Apr 23, 14:37

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP6a0e70d7163c: PHPDoc: Correct marker in one class header.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

aphront/

site/

AphrontRoutingResult.php

2 lines

14%

O1: Blessed Committers

Diff 2850

View Options

src/aphront/site/AphrontRoutingResult.php

PHPDoc: Correct marker in one class headerClosedPublicActions