Differential D25907

Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.php
ClosedPublic
Actions

Authored by Sten on Mar 13 2025, 14:45.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16012: DivinerArticleAtomizer.php fails with passing null to strlen error under PHP 8.1

Commits

rP3e2d5e4bace1: Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.php

Summary

Fix the strlen(null) error in DivinerArticleAtomizer.php

Fixes T16012

Test Plan

Create Test.book and test.md as per T16012, then run:

/phorge/bin/diviner generate --book Test.book

Diff Detail

Repository

rP Phorge

Branch

DivinerArticleAtomizer (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1777
Build 1777: arc lint + arc unit

Event Timeline

Sten created this revision.Mar 13 2025, 14:45

Owners added a reviewer: O1: Blessed Committers.Mar 13 2025, 14:45

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 13 2025, 14:45

Sten requested review of this revision.Mar 13 2025, 14:45

Harbormaster completed remote builds in B1777: Diff 2740.Mar 13 2025, 14:45

sgtm

Thanks :)

This revision is now accepted and ready to land.Mar 13 2025, 22:35

Closed by commit rP3e2d5e4bace1: Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.php. · Explain WhyMar 14 2025, 09:11

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP3e2d5e4bace1: Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.php.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

diviner/

atomizer/

DivinerArticleAtomizer.php

2 lines

10%

O1: Blessed Committers

Diff 2740

View Options

src/applications/diviner/atomizer/DivinerArticleAtomizer.php

Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.phpClosedPublicActions