Page MenuHomePhorge
Differential D25906

Facts and Charts: Add more PHPDoc coverage
ClosedPublic
Actions

Authored by aklapper on Fri, Mar 7, 19:12.
Tags
None
Referenced Files
F3215338: D25906.1741636710.diff
Sun, Mar 9, 19:58
F3214605: D25906.1741568388.diff
Sun, Mar 9, 00:59
F3214604: D25906.1741568359.diff
Sun, Mar 9, 00:59
F3212984: D25906.1741542767.diff
Sat, Mar 8, 17:52
F3212983: D25906.1741542688.diff
Sat, Mar 8, 17:51
F3212982: D25906.1741542609.diff
Sat, Mar 8, 17:50
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
Cigaryno
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPfa00599de5eb: Facts and Charts: Add more PHPDoc coverage
Summary

Make things a bit easier to understand.

Test Plan

Check parameters and return values for types and classes.

Diff Detail

Repository
rP Phorge
Branch
factsChartsDocs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1773
Build 1773: arc lint + arc unit

Event Timeline

aklapper created this revision.Fri, Mar 7, 19:12
Owners added a reviewer: O1: Blessed Committers.Fri, Mar 7, 19:12
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Mar 7, 19:12
aklapper requested review of this revision.Fri, Mar 7, 19:12
Harbormaster completed remote builds in B1770: Diff 2730.Fri, Mar 7, 19:12
Cigaryno accepted this revision.Sat, Mar 8, 12:52

yesyes

aklapper updated this revision to Diff 2733.Sat, Mar 8, 15:52

Add some more stuff (final change; moving on to other code areas for now)

Harbormaster completed remote builds in B1773: Diff 2733.Sat, Mar 8, 15:52
aklapper updated this revision to Diff 2734.Sat, Mar 8, 15:55

make linter happier

Harbormaster completed remote builds in B1774: Diff 2734.Sat, Mar 8, 15:55
valerio.bozzolan accepted this revision.Sun, Mar 9, 08:07

Thanksss

This revision is now accepted and ready to land.Sun, Mar 9, 08:07
Closed by commit rPfa00599de5eb: Facts and Charts: Add more PHPDoc coverage. · Explain WhySun, Mar 9, 10:12
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPfa00599de5eb: Facts and Charts: Add more PHPDoc coverage.

Revision Contents
Changeset List

Diff 2733

View Options

src/applications/fact/chart/PhabricatorChartDataQuery.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartDataset.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartFunction.php

Loading...
View Options

src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php

Loading...
View Options

src/applications/fact/engine/PhabricatorChartEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorFactEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php

Loading...
View Options

src/applications/fact/storage/PhabricatorFactIntDatapoint.php

Loading...
View Options

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0