Make things a bit easier to understand, for the start.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP0f4ab2413d8b: ManiphestReportController: Add more PHPDoc coverage
Check return values for their types and classes.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- maniphestReportDocs (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1760 Build 1760: arc lint + arc unit
Event Timeline
Comment Actions
Thanks
| src/applications/maniphest/controller/ManiphestReportController.php | ||
|---|---|---|
| 519 | I don't like hardcoding it also in PHPDoc lol Maybe better to say that "greater means big priority" (or vice-versa - I don't know lol) | |
| src/applications/maniphest/controller/ManiphestReportController.php | ||
|---|---|---|
| 519 | The docs cover the current behavior. ;) I'll leave understanding Priority integers as an exercise to admins and developers if anyone ever wants to dig into that. | |
| src/applications/maniphest/controller/ManiphestReportController.php | ||
|---|---|---|
| 519 | This is a nightmare for my dreams but I have already approved so... asd But better to explain what it is than to explain its current value | |