The second parameter in the message %s updated %s attached file(s), added %s: %s; removed %s: %s; modified %s: %s. did not take the number of modified files into account but only added and removed files.
Closes T15959
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15959: Modified files not counted in total when attaching files
- Commits
- rP44c7bfb42ddf: Include number of modified files in total of attached files
Read the code.
Additionally, update and remove and modify files attached to a task and count.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15959 (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 1738 Build 1738: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 768 ms | PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 833 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 379 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 385 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| 2,583 ms | PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed. | |
| View Full Test Results (1 Failed · 6 Passed) |
Event Timeline
Comment Actions
Yuuum. As I mentioned downstream ( https://phabricator.wikimedia.org/T380361#10778444 ) I think probably, fortunately, nobody noticed this in a real world, since it's complicated to cause this condition using the API, and probably impossible from the web interface, but this still seems somehow a reasonable workflow and not dead code and the change makes sense. Thaaaanks