Paths

Table of Contentst

Differential D25890

Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source
ClosedPublic
Actions

Authored by aklapper on Feb 18 2025, 23:29.

Tags

None

Referenced Files

	F3299832: D25890.1743029103.diff
	Tue, Mar 25, 22:45

	F3299527: D25890.1743023552.diff
	Tue, Mar 25, 21:12

	F3299390: D25890.1743020406.diff
	Tue, Mar 25, 20:20

	F3297624: D25890.1742987265.diff
	Tue, Mar 25, 11:07

	F3296156: D25890.1742969509.diff
	Tue, Mar 25, 06:11

	F3293805: D25890.1742923083.diff
	Mon, Mar 24, 17:18

	F3282167: D25890.1742708656.diff
	Sat, Mar 22, 05:44

	F3248560: D25890.1742261872.diff
	Mon, Mar 17, 01:37

View All 39 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16000: PHP 8.1 "ltrim(null)" exception creating a Nuance source

Commits

rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source

Summary

Passing null as the first parameter to ltrim() is deprecated since PHP 8.1.
Thus change the optional parameter of the function from null to an empty string.

ERROR 8192: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/src/applications/nuance/source/NuanceSourceDefinition.php:211]

Closes T16000

Test Plan

Create a Nuance queue at /nuance/queue/edit/form/default/
Create a Nuance "Web Form" type source at /nuance/source/edit/form/default/

Diff Detail

Repository

Branch

T16000 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1737
Build 1737: arc lint + arc unit

Event Timeline

aklapper created this revision.Feb 18 2025, 23:29

Owners added a reviewer: O1: Blessed Committers.Feb 18 2025, 23:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 18 2025, 23:29

aklapper requested review of this revision.Feb 18 2025, 23:29

Harbormaster completed remote builds in B1730: Diff 2678.Feb 18 2025, 23:29

Another option is just declaring $path = '' as default in 209 maybe

This revision is now accepted and ready to land.Feb 19 2025, 08:11

Do the easier and more obvious thing that Valerio proposed

Harbormaster completed remote builds in B1737: Diff 2685.Feb 20 2025, 18:07

aklapper edited the summary of this revision. (Show Details)Feb 20 2025, 18:09

Closed by commit rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source. · Explain WhyFeb 20 2025, 18:10

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP5b8713889487: Fix PHP 8.1 "ltrim(null)" exception creating a Nuance Source.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

nuance/

source/

NuanceSourceDefinition.php

2 lines

6%

Loading...

O1: Blessed Committers

Diff 2685

src/applications/nuance/source/NuanceSourceDefinition.php

Loading...