PHP 8.4: Do not pass null to exit() in PhutilArgumentParser
AbandonedPublic
Actions

Authored by aklapper on Feb 17 2025, 18:57.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15990: ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [arcanist/src/parser/argument/PhutilArgumentParser.php:494] on PHP 8.4

Summary

Per the Changelog at https://www.php.net/manual/en/function.exit.php, since PHP 8.4.0, "exit() is now a proper function, therefore it follows the usual type juggling semantics is affected by the strict_types declare".

ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [/arcanist/src/parser/argument/PhutilArgumentParser.php:494]

Closes T15990

Test Plan

Run ./bin/arc diff --create --help under PHP 8.4 and check for additional final output.

Diff Detail

Repository

rARC Arcanist

Branch

T15990 (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1726
Build 1726: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	661 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'. #0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(87): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture)) #1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
	45 ms	ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed.
	45 ms	ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed.
	45 ms	ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed.
	44 ms	ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed.
		View Full Test Results (1 Failed · 99 Passed)