Followup to rPf8b8d88
Rename uncalled newNoMenuItemsView() to newNoContentView() overwriting this method in the parent class, to fix showing more specific UI messages for empty portals.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers
Code:
- Grep the code for non-existing newNoMenuItemsView
- Check code of parent class PhabricatorProfileMenuEngine
Workflows:
- Create an empty portal via http://phorge.localhost/portal/edit/form/default/, see correct (more specific) string "Use "Edit Menu" to add menu items to this portal." displayed
- Click "Edit Menu" to go to http://phorge.localhost/portal/view/1/configure/global/ of that Portal just created, on the right in "Add New Menu Item..." select "Divider" and click "Create Menu Item" button, go back to portal, see correct (more specific) string "None of the visible menu items in this portal can render any content." displayed
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- portalProfileMenu
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1677 Build 1677: arc lint + arc unit
Event Timeline
| src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php | ||
|---|---|---|
| 34–35 | Interestingly, the method newNoMenuItemsView() seems orphan! $ grep -RF -- '->newNoMenuItemsView' . no results So probably we can just drop this method | |
| src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php | ||
|---|---|---|
| 34–35 | Uh right, thanks, seems https://we.phorge.it/rPdfe47157d322d3500f5eee204672cdb3d2c32c16 removed all except for this one, and creating an empty portal shows the strings defined in src/applications/search/engine/PhabricatorProfileMenuEngine.php instead. | |
| src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php | ||
|---|---|---|
| 34–35 | Last comment promise... but I discovered that renaming to newNoContentView() ... renders something! with: protected function newNoContentView(array $items) { $object = $this->getProfileObject(); $builtins = $this->getBuiltinProfileItems($object); if (count($items) <= count($builtins)) { return $this->newEmptyView( pht('New Portal'), pht('Use "Edit Menu" to add menu items to this portal.')); } else { return $this->newEmptyView( pht('No Portal Content'), pht( 'None of the visible menu items in this portal can render any '. 'content.'), ); } } With:
In this case the test plan would be:
| |
Comment Actions
Right, PhabricatorDashboardPortalProfileMenuEngine extends PhabricatorProfileMenuEngine so we can override newNoContentView()... that probably makes most sense, thanks
Comment Actions
having a portal with something useful (e.g. a Dashboard): shows the Dashboard
I have no freaking idea how to make portals show something useful, and I never understood the difference between portals and dashboards anyway, so I think I don't care. :)
Comment Actions
As I uploaded a new diff now how do I request a new review / reset the existing one "Changes Requested"?
"Foist Upon", or which vaguely named oh so "funny" option from the "Add Action..." dropdown which makes non-native speakers feel stupid and be scared to choose the wrong option? Oh UX and usability...
