Page MenuHomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
ClosedPublic

Authored by aklapper on Jul 28 2024, 14:44.
Tags
None
Referenced Files
F3387466: D25751.1744437041.diff
Fri, Apr 11, 05:50
F3376493: D25751.1744324959.diff
Wed, Apr 9, 22:42
F3374184: D25751.1744284547.diff
Wed, Apr 9, 11:29
F3355000: D25751.1743868274.diff
Fri, Apr 4, 15:51
F3327059: D25751.1743431880.diff
Sun, Mar 30, 14:38
F3321118: D25751.1743346388.diff
Sat, Mar 29, 14:53
F3300727: D25751.1743045444.diff
Wed, Mar 26, 03:17
F3298767: D25751.1743008823.diff
Tue, Mar 25, 17:07

Details

Summary

PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan

Run static code analysis; read/grep the codebase.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable