Page MenuHomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
ClosedPublic

Authored by aklapper on Jul 28 2024, 14:44.
Tags
None
Referenced Files
F4076702: D25751.1746878788.diff
Fri, May 9, 12:06
F4015661: D25751.1746642734.diff
Tue, May 6, 18:32
F3720308: D25751.1745708263.diff
Fri, Apr 25, 22:57
F3712428: D25751.1745680811.diff
Fri, Apr 25, 15:20
F3709352: D25751.1745648435.diff
Fri, Apr 25, 06:20
F3701625: D25751.1745601839.diff
Thu, Apr 24, 17:23
F3695732: D25751.1745598381.diff
Thu, Apr 24, 16:26
F3672901: D25751.1745473312.diff
Wed, Apr 23, 05:41

Details

Summary

PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan

Run static code analysis; read/grep the codebase.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable