Add explicit cast to ArcanistUnitConsoleRenderer unit test
ClosedPublic
Actions

Authored by aklapper on Dec 19 2024, 10:36.

Tags

Referenced Files

	F2916252: D25856.1737474707.diff
	Mon, Jan 20, 15:51

	F2915206: D25856.1737467829.diff
	Mon, Jan 20, 13:57

	F2913028: D25856.1737421057.diff
	Mon, Jan 20, 00:57

	F2906833: D25856.1737360749.diff
	Sun, Jan 19, 08:12

	F2904658: D25856.1737331475.diff
	Sun, Jan 19, 00:04

	F2904657: D25856.1737331474.diff
	Sun, Jan 19, 00:04

	F2904633: D25856.1737331127.diff
	Sat, Jan 18, 23:58

	F2904614: D25856.1737330922.diff
	Sat, Jan 18, 23:55

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARCec68f53ba2d6: Add explicit cast to ArcanistUnitConsoleRenderer unit test

Summary

D25848 was incomplete. $seconds itself is not an int but a float.
Thus explicitly also cast $seconds to int to avoid an error in PHP 8.1 and later.

Test Plan

Run bin/arc unit --everything

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Dec 19 2024, 10:36

Owners added a reviewer: O1: Blessed Committers.Dec 19 2024, 10:36

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 19 2024, 10:36

aklapper requested review of this revision.Dec 19 2024, 10:36

Harbormaster completed remote builds in B1665: Diff 2592.Dec 19 2024, 10:36

yesyes

This revision is now accepted and ready to land.Dec 19 2024, 10:44

Cigaryno added a project: Arcanist.Sun, Dec 29, 13:20

Closed by commit rARCec68f53ba2d6: Add explicit cast to ArcanistUnitConsoleRenderer unit test. · Explain WhyWed, Jan 15, 13:41

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARCec68f53ba2d6: Add explicit cast to ArcanistUnitConsoleRenderer unit test.

Revision Contents
Changeset List

Path

Size

Packages

src/

unit/

renderer/

ArcanistUnitConsoleRenderer.php

2 lines

O1: Blessed Committers

Diff 2605

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Add explicit cast to ArcanistUnitConsoleRenderer unit testClosedPublicActions