JSON rendering: Avoid exception iterating on non-iterable objects
ClosedPublic
Actions

Authored by aklapper on Dec 11 2024, 20:14.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARCf0176263a7e6: JSON rendering: Avoid exception iterating on non-iterable objects

Summary

Check for is_iterable($object) (available since PHP 7.1) to avoid an exception calling foreach on $object in the rare case that the object is a custom Phorge class (PHUIBoxView, PhutilSafeHTML) and not an array. cf https://we.phorge.it/rARC7570dd0da119627ff83bc6db3be06b51eb5b366b for a similar patch to handle PHP stdClass objects.

See downstream https://phabricator.wikimedia.org/T373316.

Test Plan

Unclear to reproduce the actual issue, likely something Feed related.
Open an existing JSON Paste at http://phorge.localhost/P1 and see that it still renders.
Open an existing JSON File at http://phorge.localhost/F1 and see that it still renders.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Dec 11 2024, 20:14

Owners added a reviewer: O1: Blessed Committers.Dec 11 2024, 20:14

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 11 2024, 20:14

aklapper requested review of this revision.Dec 11 2024, 20:14

Harbormaster completed remote builds in B1663: Diff 2588.Dec 11 2024, 20:14

I see a red light in a unit test but it works on me after the patch src/parser/__tests__/ArcanistBundleTestCase.php - any comment on that? Anyway sgtm since it needs the foreach() stuff later.

sgtm