Page MenuHomePhorge

Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data
ClosedPublic

Authored by aklapper on Dec 5 2024, 22:38.
Tags
None
Referenced Files
F2946012: D25849.1738380281.diff
Fri, Jan 31, 03:24
F2931406: D25849.1737707309.diff
Thu, Jan 23, 08:28
F2925835: D25849.1737633174.diff
Wed, Jan 22, 11:52
F2925061: D25849.1737589187.diff
Tue, Jan 21, 23:39
F2880613: D25849.1737080403.diff
Thu, Jan 16, 02:20
F2875350: D25849.1736978919.diff
Tue, Jan 14, 22:08
F2875349: D25849.1736978917.diff
Tue, Jan 14, 22:08
F2875348: D25849.1736978915.diff
Tue, Jan 14, 22:08

Details

Summary

Do not throw an exception when passing bogus parameters to hovercards but properly handle the missing array index by setting $object_phid to null.
In consequence, see a proper hovercard correctly displaying Unknown Object (????) instead of an exception.

Closes T15969

Test Plan

Diff Detail

Repository
rP Phorge
Branch
T15969hovercards (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1648
Build 1648: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.Dec 5 2024, 22:38

Thaaanks - If I'm not wrong we can = idx($card, 'objectPHID');

This revision is now accepted and ready to land.Dec 5 2024, 22:57

Right... one day I may get used to all those Phorge shortcuts, thanks